New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent ansible_facts injection #68431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also only replace when needed - switched from replace to index - added test to verify bogus_facts are not accepted
ansibot
added
affects_2.10
This issue/PR affects Ansible v2.10
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
labels
Mar 24, 2020
bcoca
added
the
P1
Priority 1 - Immediate Attention Required; Release Immediately After Fixed
label
Mar 24, 2020
mattclay
reviewed
Mar 24, 2020
bcoca
removed
the
needs_triage
Needs a first human triage before being processed.
label
Mar 24, 2020
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Mar 24, 2020
- also only replace when needed - switched from replace to index - added test to verify bogus_facts are not accepted CVE-2020-10684 (cherry picked from commit a9d2cea)
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Mar 24, 2020
- also only replace when needed - switched from replace to index - added test to verify bogus_facts are not accepted CVE-2020-10684 (cherry picked from commit a9d2cea)
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Mar 24, 2020
- also only replace when needed - switched from replace to index - added test to verify bogus_facts are not accepted CVE-2020-10684 (cherry picked from commit a9d2cea)
@mattclay when will we publish the fix ,any schedule? |
This was referenced Mar 31, 2020
mattclay
pushed a commit
that referenced
this pull request
Apr 15, 2020
- also only replace when needed - switched from replace to index - added test to verify bogus_facts are not accepted CVE-2020-10684 (cherry picked from commit a9d2cea)
mattclay
pushed a commit
that referenced
this pull request
Apr 15, 2020
* prevent ansible_facts injection (#68431) - also only replace when needed - switched from replace to index - added test to verify bogus_facts are not accepted CVE-2020-10684 (cherry picked from commit a9d2cea) * added to ignore
mattclay
pushed a commit
that referenced
this pull request
Apr 15, 2020
* prevent ansible_facts injection (#68431) - also only replace when needed - switched from replace to index - added test to verify bogus_facts are not accepted CVE-2020-10684 (cherry picked from commit a9d2cea) * add to ignore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.10
This issue/PR affects Ansible v2.10
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
P1
Priority 1 - Immediate Attention Required; Release Immediately After Fixed
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2020-10684
ISSUE TYPE
COMPONENT NAME
facts